Protokoll #4796

{
    "event": "PreToolUse",
    "tool_name": "mcp__mcp-tasks__tasks_list",
    "tool_input": {
        "search": "refactoring",
        "compact": false
    }
}

{
    "tool_response": [
        {
            "type": "text",
            "text": "{\n  \"success\": true,\n  \"tasks\": [\n    {\n      \"id\": 232,\n      \"uuid\": \"e5c42e0a-36ad-4d37-86e3-3035fd13bde7\",\n      \"title\": \"Phase 5: ChatController Refactoring (Proof-of-Concept)\",\n      \"description\": \"## Anweisungen für KI-System\\n1. Lies `\/var\/www\/CLAUDE.md` für Projektkontext\\n2. Lies aktuellen Controller: `Read(\\\"\/src\/Controller\/ChatController.php\\\")`\\n3. Prüfe Contract: `contracts_validate(name=\\\"code-quality-standards\\\")`\\n\\n## Kontext\\nChatController ist der \\\"God Object\\\" aus der Supervision (711 LOC, 12 PDO-Zugriffe).\\nDieser Task ist Proof-of-Concept für alle anderen Controller-Refactorings.\\n\\n## Ziel\\nVon 711 LOC auf < 150 LOC durch Extraktion in:\\n- ChatRepository (SQL)\\n- ChatSessionService (Logik)\\n- ChatMessageFormatter (Formatierung)\\n- Commands (Validierung)\\n\\n## Schritt-für-Schritt\\n\\n### 1. ChatRepository erstellen\\nExtrahiere alle SQL-Queries aus ChatController:\\n```php\\n\/\/ \/src\/Infrastructure\/Persistence\/ChatRepository.php\\nfinal class ChatRepository\\n{\\n    public function findSessionByUuid(string $uuid): ?array\\n    public function findSessionsByUserId(?int $userId): array\\n    public function createSession(string $uuid, ?int $userId): int\\n    public function saveMessage(int $sessionId, string $role, string $content): int\\n    public function getSessionMessages(int $sessionId): array\\n    public function updateSessionTitle(int $sessionId, string $title): void\\n    public function deleteSession(int $sessionId): void\\n}\\n```\\n\\n### 2. ChatSessionService erstellen\\nExtrahiere Geschäftslogik:\\n```php\\n\/\/ \/src\/Application\/ChatSessionService.php\\nfinal class ChatSessionService\\n{\\n    public function startSession(?int $userId): Session\\n    public function getOrCreateSession(string $uuid): Session\\n    public function sendMessage(string $sessionId, string $content): Message\\n    public function generateResponse(string $sessionId, string $model): Response\\n    public function getHistory(string $sessionId): array\\n    public function deleteSession(string $sessionId): void\\n}\\n```\\n\\n### 3. Commands erstellen\\n```php\\n\/\/ \/src\/Application\/Command\/SendChatMessageCommand.php\\nfinal class SendChatMessageCommand\\n{\\n    public static function fromRequest(array $data): self\\n    public function validate(): array\\n}\\n```\\n\\n### 4. Controller refactoren\\n```php\\n\/\/ \/src\/Controller\/ChatController.php (Ziel: < 150 LOC)\\nfinal class ChatController extends Controller\\n{\\n    public function __construct(\\n        private ChatSessionService $chatService,\\n        private ChatMessageFormatter $formatter\\n    ) {}\\n    \\n    public function index(): void\\n    {\\n        $sessions = $this->chatService->getUserSessions();\\n        $this->view('chat\/index', ['sessions' => $sessions]);\\n    }\\n    \\n    public function show(string $uuid): void\\n    {\\n        $session = $this->chatService->getOrCreateSession($uuid);\\n        $messages = $this->formatter->formatAll($session->messages);\\n        $this->view('chat\/show', compact('session', 'messages'));\\n    }\\n    \\n    public function sendMessage(): void\\n    {\\n        $command = SendChatMessageCommand::fromRequest($_POST);\\n        if ($errors = $command->validate()) {\\n            return $this->json(['errors' => $errors], 400);\\n        }\\n        \\n        $message = $this->chatService->sendMessage($command);\\n        $this->partial('chat\/message', ['message' => $message]);\\n    }\\n    \\n    public function generate(): void\\n    {\\n        $response = $this->chatService->generateResponse(\\n            $_POST['session_id'],\\n            $_POST['model'] ?? 'mistral'\\n        );\\n        $this->partial('chat\/message', ['message' => $response]);\\n    }\\n}\\n```\\n\\n## Validierung nach Refactoring\\n```bash\\n# LOC prüfen\\nwc -l src\/Controller\/ChatController.php  # Ziel: < 150\\n\\n# Contract validieren\\ncontracts_validate(name=\\\"code-quality-standards\\\")  # Ziel: 0 critical\\n```\\n\\n## Akzeptanzkriterien\\n- [ ] ChatController < 150 LOC\\n- [ ] Kein PDO\/SQL im Controller\\n- [ ] Kein Parsedown im Controller\\n- [ ] Alle Tests bestehen (falls vorhanden)\\n- [ ] Funktionalität unverändert\",\n      \"type\": \"ai_task\",\n      \"status\": \"completed\",\n      \"created_by\": \"mcp-tasks\",\n      \"created_by_type\": \"ai\",\n      \"parent_task_id\": 221,\n      \"due_date\": null,\n      \"created_at\": \"2025-12-22T09:59:25.068413\",\n      \"updated_at\": \"2025-12-22T14:35:46.872935\",\n      \"completed_at\": \"2025-12-22T14:35:46.872938\",\n      \"metadata\": {}\n    },\n    {\n      \"id\": 226,\n      \"uuid\": \"77d2320d-f550-4acf-af54-aeba0dbbfd90\",\n      \"title\": \"Phase 2.2: Command\/Query-Objekte einführen\",\n      \"description\": \"## Anweisungen für KI-System\\n1. Lies `\/var\/www\/CLAUDE.md` für Projektkontext\\n2. Analysiere Request-Handling in Controllern\\n3. Prüfe Contracts: `contracts_validate()`\\n\\n## Problem (Supervision #5, #7)\\n- Eingaben werden ad-hoc aus $_POST\/$_GET gelesen\\n- Validierung verstreut und dupliziert\\n- Keine klaren Schnittstellen zwischen Schichten\\n\\n## Zielarchitektur\\n```\\nRequest → Command-Objekt → Validierung → Service → Response\\n```\\n\\n## Zu erstellende Commands\\n\\n### Content-Bereich\\n```php\\n\/\/ \/src\/Application\/Command\/CreateContentOrderCommand.php\\nfinal class CreateContentOrderCommand\\n{\\n    public function __construct(\\n        public readonly string $briefing,\\n        public readonly string $model,\\n        public readonly array $collections,\\n        public readonly int $contextLimit = 3,\\n    ) {}\\n    \\n    public static function fromRequest(array $data): self\\n    {\\n        return new self(\\n            briefing: $data['briefing'] ?? '',\\n            model: $data['model'] ?? 'mistral',\\n            collections: $data['collections'] ?? [],\\n            contextLimit: (int)($data['context_limit'] ?? 3),\\n        );\\n    }\\n    \\n    public function validate(): array\\n    {\\n        $errors = [];\\n        if (empty($this->briefing)) {\\n            $errors[] = 'Briefing ist erforderlich';\\n        }\\n        if (!in_array($this->model, ['mistral', 'llama3', 'claude'])) {\\n            $errors[] = 'Ungültiges Modell';\\n        }\\n        return $errors;\\n    }\\n}\\n```\\n\\n### Chat-Bereich\\n```php\\nfinal class SendChatMessageCommand\\n{\\n    public function __construct(\\n        public readonly string $sessionId,\\n        public readonly string $content,\\n        public readonly ?string $model = null,\\n    ) {}\\n}\\n```\\n\\n### Critic-Bereich\\n```php\\nfinal class CreateCriticCommand\\n{\\n    public function __construct(\\n        public readonly string $name,\\n        public readonly string $systemPrompt,\\n        public readonly string $evaluationPrompt,\\n        public readonly bool $isActive = true,\\n    ) {}\\n}\\n```\\n\\n## Verzeichnisstruktur\\n```\\n\/src\/Application\/\\n├── Command\/\\n│   ├── CreateContentOrderCommand.php\\n│   ├── SendChatMessageCommand.php\\n│   ├── CreateCriticCommand.php\\n│   └── UpdatePromptCommand.php\\n└── Query\/\\n    ├── GetSessionHistoryQuery.php\\n    ├── SearchProtokollQuery.php\\n    └── ListContentOrdersQuery.php\\n```\\n\\n## Controller-Refactoring\\n```php\\n\/\/ VORHER\\npublic function create(): void {\\n    $briefing = $_POST['briefing'] ?? '';\\n    $model = $_POST['model'] ?? 'mistral';\\n    \/\/ ... Validierung verstreut\\n}\\n\\n\/\/ NACHHER\\npublic function create(): void {\\n    $command = CreateContentOrderCommand::fromRequest($_POST);\\n    $errors = $command->validate();\\n    if ($errors) {\\n        return $this->view('error', ['errors' => $errors]);\\n    }\\n    $result = $this->contentService->createOrder($command);\\n    return $this->redirect('\/content\/' . $result->id);\\n}\\n```\\n\\n## Akzeptanzkriterien\\n- [ ] Mindestens 6 Command-Klassen erstellt\\n- [ ] Zentrale Validierung in Commands\\n- [ ] Controller nutzen Commands statt direkter $_POST-Zugriffe\",\n      \"type\": \"ai_task\",\n      \"status\": \"pending\",\n      \"created_by\": \"mcp-tasks\",\n      \"created_by_type\": \"ai\",\n      \"parent_task_id\": 221,\n      \"due_date\": null,\n      \"created_at\": \"2025-12-22T09:57:26.464390\",\n      \"updated_at\": \"2025-12-22T09:57:26.464392\",\n      \"completed_at\": null,\n      \"metadata\": {}\n    },\n    {\n      \"id\": 223,\n      \"uuid\": \"70c40b39-d68b-4919-8791-bcd04ca06f1a\",\n      \"title\": \"Phase 1.1: DatabaseFactory als einzige DB-Quelle\",\n      \"description\": \"## Anweisungen für KI-System\\n1. Lies `\/var\/www\/CLAUDE.md` für Projektkontext\\n2. Nutze MCP-DB für Recherche: `db_tables()`, `db_describe()`\\n3. Prüfe Contracts: `contracts_get(name=\\\"layered-architecture\\\")`\\n\\n## Problem (Supervision #2, #4)\\nAktuell gemischte Patterns:\\n- Direkte PDO-Instanziierung in Controllern\\n- DatabaseFactory an manchen Stellen\\n- Inkonsistentes Connection-Management\\n\\n## Aufgabe\\n1. **Analyse**: Finde alle Stellen mit direktem `new PDO` oder `$this->db`\\n   ```bash\\n   grep -rn \\\"new PDO\\\\|private.*PDO\\\\|\\\\$this->db\\\" src\/\\n   ```\\n\\n2. **DatabaseFactory erweitern** (`\/src\/Infrastructure\/DatabaseFactory.php`):\\n   - Singleton-Pattern für Connection\\n   - Zentrale Konfiguration aus Environment\\n   - Transaction-Support\\n\\n3. **Refactoring**:\\n   - Alle `new PDO()` durch `DatabaseFactory::getConnection()` ersetzen\\n   - PDO-Properties aus Controllern entfernen\\n\\n## Zielzustand\\n```php\\n\/\/ VORHER (Controller)\\nprivate \\\\PDO $db;\\npublic function __construct() {\\n    $this->db = new \\\\PDO(...);\\n}\\n\\n\/\/ NACHHER (Repository via DI)\\npublic function __construct(private TaskRepository $taskRepo) {}\\n```\\n\\n## Dateien\\n- `\/src\/Infrastructure\/DatabaseFactory.php` (erweitern)\\n- Alle Controller mit `private \\\\PDO $db`\\n\\n## Akzeptanzkriterien\\n- [ ] Keine `new PDO()` außerhalb DatabaseFactory\\n- [ ] Alle Repositories nutzen DatabaseFactory\\n- [ ] Connection-Konfiguration zentral\",\n      \"type\": \"ai_task\",\n      \"status\": \"completed\",\n      \"created_by\": \"mcp-tasks\",\n      \"created_by_type\": \"ai\",\n      \"parent_task_id\": 221,\n      \"due_date\": null,\n      \"created_at\": \"2025-12-22T09:56:35.505235\",\n      \"updated_at\": \"2025-12-22T10:13:11.163616\",\n      \"completed_at\": \"2025-12-22T10:13:11.163620\",\n      \"metadata\": {}... [TRUNCATED-b7a4a1b5547ac312]"
        }
    ]
}