{
"event": "PreToolUse",
"tool_name": "Write",
"tool_input": {
"file_path": "\/var\/www\/dev.campus.systemische-tools.de\/docs\/codequality\/02-dry-kiss-violations.md",
"content": "# DRY\/KISS Violations Report\n\n**Projekt:** dev.campus.systemische-tools.de\n**Analysedatum:** 2025-12-22\n\n---\n\n## DRY (Don't Repeat Yourself) Violations\n\n### 1. JSON Decoding Pattern (9+ Duplikate)\n\n**Pattern:**\n```php\njson_decode($chunk['heading_path'] ?? '[]', true) ?: []\n```\n\n**Fundstellen:**\n| Datei | Zeile |\n|-------|-------|\n| Api\/ExplorerController.php | 383 |\n| SemanticExplorerController.php | 81, 134, 208 |\n| SystemExplorerController.php | 389 |\n| ChunkSyncService.php | 278, 356 |\n| ChunkAnalysisService.php | 108 |\n| HybridSearchService.php | 308 |\n\n**Empfehlung:** Utility-Klasse oder Trait erstellen:\n```php\ntrait JsonDecodeTrait {\n protected function decodeJsonArray(?string $json): array {\n return json_decode($json ?? '[]', true) ?: [];\n }\n}\n```\n\n---\n\n### 2. HTTP 404 Response Pattern (32 Duplikate)\n\n**Pattern:**\n```php\nhttp_response_code(404);\necho '404 - Nicht gefunden';\nreturn;\n```\n\n**Fundstellen (Auswahl):**\n- ChatController.php: 219, 251, 278\n- SemanticExplorerController.php: 71, 127, 295, 476, 581, 678, 781\n- SystemExplorerController.php: 128, 246, 379\n- ConfigController.php: 137, 163, 191, 256\n- ContentController.php: 155, 190\n- ContractController.php: 97, 122, 144, 191, 214\n- DocsController.php: 35, 51, 99, 117\n- BackupRestoreController.php: 63, 115\n- ProtokollController.php: 121\n\n**Empfehlung:** Base Controller erweitern:\n```php\n\/\/ Framework\/Controller.php\nprotected function notFound(string $message = 'Nicht gefunden'): never {\n http_response_code(404);\n if ($this->isJsonRequest()) {\n $this->json(['error' => $message], 404);\n } else {\n echo \"404 - {$message}\";\n }\n exit;\n}\n```\n\n---\n\n### 3. GET Parameter Handling (8+ Duplikate)\n\n**Pattern:**\n```php\n$search = $_GET['search'] ?? '';\n$page = max(1, (int)($_GET['page'] ?? 1));\n$limit = min(50, max(1, (int)($_GET['limit'] ?? 10)));\n```\n\n**Fundstellen:**\n| Datei | Zeile |\n|-------|-------|\n| Api\/ExplorerController.php | 171, 296 |\n| SemanticExplorerController.php | 50, 98, 272 |\n| SystemExplorerController.php | 186, 291 |\n| ProtokollController.php | 45 |\n\n**Empfehlung:** Input-Helper-Trait:\n```php\ntrait InputHelperTrait {\n protected function getSearch(): string {\n return trim($_GET['search'] ?? '');\n }\n\n protected function getPage(): int {\n return max(1, (int)($_GET['page'] ?? 1));\n }\n\n protected function getLimit(int $max = 50, int $default = 10): int {\n return min($max, max(1, (int)($_GET['limit'] ?? $default)));\n }\n}\n```\n\n---\n\n### 4. Pagination Logic (6+ Duplikate)\n\n**Pattern:**\n```php\n$page = max(1, (int)($_GET['page'] ?? 1));\n$limit = 50;\n$offset = ($page - 1) * $limit;\n\/\/ ... query\n$totalPages = ceil($totalCount \/ $limit);\n```\n\n**Fundstellen:**\n- SemanticExplorerController.php: chunks(), semantik()\n- SystemExplorerController.php: chunks()\n- Api\/ExplorerController.php: listSeiten(), listChunks()\n- ProtokollController.php: index()\n\n**Empfehlung:** Pagination-Value-Object:\n```php\nclass Pagination {\n public function __construct(\n public readonly int $page,\n public readonly int $limit,\n public readonly int $offset,\n public readonly int $totalCount = 0\n ) {}\n\n public static function fromRequest(int $defaultLimit = 50): self {\n $page = max(1, (int)($_GET['page'] ?? 1));\n return new self($page, $defaultLimit, ($page - 1) * $defaultLimit);\n }\n\n public function withTotalCount(int $count): self {\n return new self($this->page, $this->limit, $this->offset, $count);\n }\n\n public function totalPages(): int {\n return (int)ceil($this->totalCount \/ $this->limit);\n }\n}\n```\n\n---\n\n### 5. CSRF Validation Pattern\n\n**Bereits geloest:** `$this->requireCsrf()` existiert in Base Controller.\n**Status:** OK\n\n---\n\n### 6. SQL Query Building mit Filtern\n\n**Pattern:**\n```php\n$sql = 'SELECT ... WHERE 1=1';\n$params = [];\nif ($filter !== '') {\n $sql .= ' AND column = :filter';\n $params['filter'] = $filter;\n}\n$sql .= ' ORDER BY ... LIMIT :limit OFFSET :offset';\n```\n\n**Fundstellen:** 10+ in verschiedenen Controllern und Repositories\n\n**Empfehlung:** Query Builder oder Specification Pattern\n\n---\n\n## KISS (Keep It Simple, Stupid) Violations\n\n### 1. Komplexe Methoden (>50 LOC)\n\n| Datei | Methode | LOC | Komplexitaet |\n|-------|---------|-----|--------------|\n| ChatController.php | `chat()` | ~200 | HOCH |\n| ChatController.php | `initializeDatabase()` | ~80 | MITTEL |\n| SemanticExplorerController.php | `entitaetShow()` | ~50 | MITTEL |\n| SystemExplorerController.php | `dokumentShow()` | ~60 | MITTEL |\n| ContentController.php | `store()` | ~65 | MITTEL |\n\n**Empfehlung:** Methoden auf max. 30 LOC beschraenken, Teillogik in private Helper oder Services auslagern.\n\n---\n\n### 2. Controller mit HTML-Rendering\n\n**Problem:** Controller enthalten HTML-Rendering-Logik\n\n**Beispiel ContentController.php:394-417:**\n```php\nprivate function renderVersionPartial(array $result): void {\n echo '<div class=\"version-content\">';\n echo '<div class=\"version-header\">';\n \/\/ ... 20+ Zeilen HTML\n}\n```\n\n**Empfehlung:** In View-Templates auslagern oder Partial-System nutzen.\n\n---\n\n### 3. Hardcoded URLs in Code\n\n**Fundstellen:**\n```php\n\/\/ SemanticExplorerController.php:221\ncurl_init('http:\/\/localhost:11434\/api\/embeddings')\n\n\/\/ SemanticExplorerController.php:245\ncurl_init('http:\/\/localhost:6333\/collections\/documents\/points\/search')\n```\n\n**Empfehlung:** In Konfiguration auslagern.\n\n---\n\n### 4. Magic Numbers\n\n**Beispiele:**\n```php\n$limit = 50; \/\/ Woher kommt 50?\n$limit = min(20, max(1, ...)); \/\/ Warum 20?\n$topKeywords = array_slice($keywordCounts, 0, 30, true); \/\/ Warum 30?\n```\n\n**Empfehlung:** Konstanten mit sprechenden Namen.\n\n---\n\n## YAGNI Violations\n\n### 1. Ungenutzte Methoden\nAnalyse erforderlich - keine offensichtlichen Violations gefunden.\n\n### 2. Over-Engineering\n**Status:** Moderat - Die aktuelle Architektur ist eher unter-engineered als over-engineered.\n\n---\n\n## Zusammenfassung\n\n| Kategorie | Violations | Prioritaet |\n|-----------|------------|------------|\n| JSON Decode Pattern | 9+ | MITTEL |\n| 404 Response Pattern | 32 | HOCH |\n| GET Parameter Handling | 8+ | MITTEL |\n| Pagination Logic | 6+ | MITTEL |\n| Komplexe Methoden | 5 | HOCH |\n| HTML in Controller | 2 | MITTEL |\n| Hardcoded URLs | 2 | NIEDRIG |\n\n**Quick Wins:**\n1. `notFound()` Methode in Base Controller\n2. `decodeJsonArray()` Utility-Methode\n3. Pagination Value Object\n4. Input Helper Trait\n"
}
}
{
"tool_response": {
"type": "create",
"filePath": "\/var\/www\/dev.campus.systemische-tools.de\/docs\/codequality\/02-dry-kiss-violations.md",
"content": "# DRY\/KISS Violations Report\n\n**Projekt:** dev.campus.systemische-tools.de\n**Analysedatum:** 2025-12-22\n\n---\n\n## DRY (Don't Repeat Yourself) Violations\n\n### 1. JSON Decoding Pattern (9+ Duplikate)\n\n**Pattern:**\n```php\njson_decode($chunk['heading_path'] ?? '[]', true) ?: []\n```\n\n**Fundstellen:**\n| Datei | Zeile |\n|-------|-------|\n| Api\/ExplorerController.php | 383 |\n| SemanticExplorerController.php | 81, 134, 208 |\n| SystemExplorerController.php | 389 |\n| ChunkSyncService.php | 278, 356 |\n| ChunkAnalysisService.php | 108 |\n| HybridSearchService.php | 308 |\n\n**Empfehlung:** Utility-Klasse oder Trait erstellen:\n```php\ntrait JsonDecodeTrait {\n protected function decodeJsonArray(?string $json): array {\n return json_decode($json ?? '[]', true) ?: [];\n }\n}\n```\n\n---\n\n### 2. HTTP 404 Response Pattern (32 Duplikate)\n\n**Pattern:**\n```php\nhttp_response_code(404);\necho '404 - Nicht gefunden';\nreturn;\n```\n\n**Fundstellen (Auswahl):**\n- ChatController.php: 219, 251, 278\n- SemanticExplorerController.php: 71, 127, 295, 476, 581, 678, 781\n- SystemExplorerController.php: 128, 246, 379\n- ConfigController.php: 137, 163, 191, 256\n- ContentController.php: 155, 190\n- ContractController.php: 97, 122, 144, 191, 214\n- DocsController.php: 35, 51, 99, 117\n- BackupRestoreController.php: 63, 115\n- ProtokollController.php: 121\n\n**Empfehlung:** Base Controller erweitern:\n```php\n\/\/ Framework\/Controller.php\nprotected function notFound(string $message = 'Nicht gefunden'): never {\n http_response_code(404);\n if ($this->isJsonRequest()) {\n $this->json(['error' => $message], 404);\n } else {\n echo \"404 - {$message}\";\n }\n exit;\n}\n```\n\n---\n\n### 3. GET Parameter Handling (8+ Duplikate)\n\n**Pattern:**\n```php\n$search = $_GET['search'] ?? '';\n$page = max(1, (int)($_GET['page'] ?? 1));\n$limit = min(50, max(1, (int)($_GET['limit'] ?? 10)));\n```\n\n**Fundstellen:**\n| Datei | Zeile |\n|-------|-------|\n| Api\/ExplorerController.php | 171, 296 |\n| SemanticExplorerController.php | 50, 98, 272 |\n| SystemExplorerController.php | 186, 291 |\n| ProtokollController.php | 45 |\n\n**Empfehlung:** Input-Helper-Trait:\n```php\ntrait InputHelperTrait {\n protected function getSearch(): string {\n return trim($_GET['search'] ?? '');\n }\n\n protected function getPage(): int {\n return max(1, (int)($_GET['page'] ?? 1));\n }\n\n protected function getLimit(int $max = 50, int $default = 10): int {\n return min($max, max(1, (int)($_GET['limit'] ?? $default)));\n }\n}\n```\n\n---\n\n### 4. Pagination Logic (6+ Duplikate)\n\n**Pattern:**\n```php\n$page = max(1, (int)($_GET['page'] ?? 1));\n$limit = 50;\n$offset = ($page - 1) * $limit;\n\/\/ ... query\n$totalPages = ceil($totalCount \/ $limit);\n```\n\n**Fundstellen:**\n- SemanticExplorerController.php: chunks(), semantik()\n- SystemExplorerController.php: chunks()\n- Api\/ExplorerController.php: listSeiten(), listChunks()\n- ProtokollController.php: index()\n\n**Empfehlung:** Pagination-Value-Object:\n```php\nclass Pagination {\n public function __construct(\n public readonly int $page,\n public readonly int $limit,\n public readonly int $offset,\n public readonly int $totalCount = 0\n ) {}\n\n public static function fromRequest(int $defaultLimit = 50): self {\n $page = max(1, (int)($_GET['page'] ?? 1));\n return new self($page, $defaultLimit, ($page - 1) * $defaultLimit);\n }\n\n public function withTotalCount(int $count): self {\n return new self($this->page, $this->limit, $this->offset, $count);\n }\n\n public function totalPages(): int {\n return (int)ceil($this->totalCount \/ $this->limit);\n }\n}\n```\n\n---\n\n### 5. CSRF Validation Pattern\n\n**Bereits geloest:** `$this->requireCsrf()` existiert in Base Controller.\n**Status:** OK\n\n---\n\n### 6. SQL Query Building mit Filtern\n\n**Pattern:**\n```php\n$sql = 'SELECT ... WHERE 1=1';\n$params = [];\nif ($filter !== '') {\n $sql .= ' AND column = :filter';\n $params['filter'] = $filter;\n}\n$sql .= ' ORDER BY ... LIMIT :limit OFFSET :offset';\n```\n\n**Fundstellen:** 10+ in verschiedenen Controllern und Repositories\n\n**Empfehlung:** Query Builder oder Specification Pattern\n\n---\n\n## KISS (Keep It Simple, Stupid) Violations\n\n### 1. Komplexe Methoden (>50 LOC)\n\n| Datei | Methode | LOC | Komplexitaet |\n|-------|---------|-----|--------------|\n| ChatController.php | `chat()` | ~200 | HOCH |\n| ChatController.php | `initializeDatabase()` | ~80 | MITTEL |\n| SemanticExplorerController.php | `entitaetShow()` | ~50 | MITTEL |\n| SystemExplorerController.php | `dokumentShow()` | ~60 | MITTEL |\n| ContentController.php | `store()` | ~65 | MITTEL |\n\n**Empfehlung:** Methoden auf max. 30 LOC beschraenken, Teillogik in private Helper oder Services auslagern.\n\n---\n\n### 2. Controller mit HTML-Rendering\n\n**Problem:** Controller enthalten HTML-Rendering-Logik\n\n**Beispiel ContentController.php:394-417:**\n```php\nprivate function renderVersionPartial(array $result): void {\n echo '<div class=\"version-content\">';\n echo '<div class=\"version-header\">';\n \/\/ ... 20+ Zeilen HTML\n}\n```\n\n**Empfehlung:** In View-Templates auslagern oder Partial-System nutzen.\n\n---\n\n### 3. Hardcoded URLs in Code\n\n**Fundstellen:**\n```php\n\/\/ SemanticExplorerController.php:221\ncurl_init('http:\/\/localhost:11434\/api\/embeddings')\n\n\/\/ SemanticExplorerController.php:245\ncurl_init('http:\/\/localhost:6333\/collections\/documents\/points\/search')\n```\n\n**Empfehlung:** In Konfiguration auslagern.\n\n---\n\n### 4. Magic Numbers\n\n**Beispiele:**\n```php\n$limit = 50; \/\/ Woher kommt 50?\n$limit = min(20, max(1, ...)); \/\/ Warum 20?\n$topKeywords = array_slice($keywordCounts, 0, 30, true); \/\/ Warum 30?\n```\n\n**Empfehlung:** Konstanten mit sprechenden Namen.\n\n---\n\n## YAGNI Violations\n\n### 1. Ungenutzte Methoden\nAnalyse erforderlich - keine offensichtlichen Violations gefunden.\n\n### 2. Over-Engineering\n**Status:** Moderat - Die aktuelle Architektur ist eher unter-engineered als over-engineered.\n\n---\n\n## Zusammenfassung\n\n| Kategorie | Violations | Prioritaet |\n|-----------|------------|------------|\n| JSON Decode Pattern | 9+ | MITTEL |\n| 404 Response Pattern | 32 | HOCH |\n| GET Parameter Handling | 8+ | MITTEL |\n| Pagination Logic | 6+ | MITTEL |\n| Komplexe Methoden | 5 | HOCH |\n| HTML in Controller | 2 | MITTEL |\n| Hardcoded URLs | 2 | NIEDRIG |\n\n**Quick Wins:**\n1. `notFound()` Methode in Base Controller\n2. `decodeJsonArray()` Utility-Methode\n3. Pagination Value Object\n4. Input Helper Trait\n",
"structuredPatch": [],
"originalFile": null
}
}