Protokoll #12445

{
    "event": "PreToolUse",
    "tool_name": "Edit",
    "tool_input": {
        "file_path": "\/var\/www\/dev.campus.systemische-tools.de\/src\/UseCases\/Content\/GenerateContentUseCase.php",
        "old_string": "    \/**\n     * Run critique on a version\n     *\/\n    public function critique(int $versionId, string $model): ContentGenerationResult\n    {\n        $result = $this->callPython('critique', $versionId, [$model]);\n\n        return ContentGenerationResult::fromPythonResult($result);\n    }",
        "new_string": "    \/**\n     * Run critique on a version (synchronous)\n     *\/\n    public function critique(int $versionId, string $model): ContentGenerationResult\n    {\n        $result = $this->callPython('critique', $versionId, [$model]);\n\n        return ContentGenerationResult::fromPythonResult($result);\n    }\n\n    \/**\n     * Start async critique (returns immediately)\n     *\n     * Note: Python script reads DB password directly from .env via config.py\n     *\/\n    public function critiqueAsync(int $orderId, int $versionId, string $model): bool\n    {\n        $scriptPath = $this->pipelinePath . '\/web_generate.py';\n        $logPath = '\/tmp\/content_critique_' . $orderId . '.log';\n\n        $cmd = sprintf(\n            'nohup %s %s critique %d %s %d > %s 2>&1 &',\n            escapeshellarg($this->pythonPath),\n            escapeshellarg($scriptPath),\n            $versionId,\n            escapeshellarg($model),\n            $orderId,\n            escapeshellarg($logPath)\n        );\n\n        exec($cmd); \/\/ nosemgrep: exec-use\n\n        return true;\n    }"
    }
}

{
    "tool_response": {
        "filePath": "\/var\/www\/dev.campus.systemische-tools.de\/src\/UseCases\/Content\/GenerateContentUseCase.php",
        "oldString": "    \/**\n     * Run critique on a version\n     *\/\n    public function critique(int $versionId, string $model): ContentGenerationResult\n    {\n        $result = $this->callPython('critique', $versionId, [$model]);\n\n        return ContentGenerationResult::fromPythonResult($result);\n    }",
        "newString": "    \/**\n     * Run critique on a version (synchronous)\n     *\/\n    public function critique(int $versionId, string $model): ContentGenerationResult\n    {\n        $result = $this->callPython('critique', $versionId, [$model]);\n\n        return ContentGenerationResult::fromPythonResult($result);\n    }\n\n    \/**\n     * Start async critique (returns immediately)\n     *\n     * Note: Python script reads DB password directly from .env via config.py\n     *\/\n    public function critiqueAsync(int $orderId, int $versionId, string $model): bool\n    {\n        $scriptPath = $this->pipelinePath . '\/web_generate.py';\n        $logPath = '\/tmp\/content_critique_' . $orderId . '.log';\n\n        $cmd = sprintf(\n            'nohup %s %s critique %d %s %d > %s 2>&1 &',\n            escapeshellarg($this->pythonPath),\n            escapeshellarg($scriptPath),\n            $versionId,\n            escapeshellarg($model),\n            $orderId,\n            escapeshellarg($logPath)\n        );\n\n        exec($cmd); \/\/ nosemgrep: exec-use\n\n        return true;\n    }",
        "originalFile": "<?php\n\ndeclare(strict_types=1);\n\nnamespace UseCases\\Content;\n\n\/\/ @responsibility: Orchestriert Content-Generierung via Python-Pipeline\n\nclass GenerateContentUseCase\n{\n    private string $pipelinePath;\n    private string $pythonPath;\n\n    \/** @var array<string> Allowed Python commands *\/\n    private const ALLOWED_COMMANDS = ['generate', 'critique', 'revise'];\n\n    public function __construct(\n        ?string $pipelinePath = null,\n        ?string $pythonPath = null\n    ) {\n        $this->pipelinePath = $pipelinePath ?? '\/var\/www\/scripts\/pipeline';\n        $this->pythonPath = $pythonPath ?? $this->pipelinePath . '\/venv\/bin\/python';\n    }\n\n    \/**\n     * Generate content for an order (synchronous)\n     *\/\n    public function generate(int $orderId, string $model, string $collection, int $contextLimit): ContentGenerationResult\n    {\n        $result = $this->callPython('generate', $orderId, [$model, $collection, $contextLimit]);\n\n        return ContentGenerationResult::fromPythonResult($result);\n    }\n\n    \/**\n     * Start async content generation (returns immediately)\n     *\n     * Note: Python script reads DB password directly from .env via config.py\n     * No need to pass credentials via environment variables\n     *\/\n    public function generateAsync(int $orderId, string $model, string $collection, int $contextLimit): bool\n    {\n        $scriptPath = $this->pipelinePath . '\/web_generate.py';\n        $logPath = '\/tmp\/content_gen_' . $orderId . '.log';\n\n        $cmd = sprintf(\n            'nohup %s %s generate %d %s %s %d > %s 2>&1 &',\n            escapeshellarg($this->pythonPath),\n            escapeshellarg($scriptPath),\n            $orderId,\n            escapeshellarg($model),\n            escapeshellarg($collection),\n            $contextLimit,\n            escapeshellarg($logPath)\n        );\n\n        exec($cmd); \/\/ nosemgrep: exec-use\n\n        return true;\n    }\n\n    \/**\n     * Run critique on a version\n     *\/\n    public function critique(int $versionId, string $model): ContentGenerationResult\n    {\n        $result = $this->callPython('critique', $versionId, [$model]);\n\n        return ContentGenerationResult::fromPythonResult($result);\n    }\n\n    \/**\n     * Create revision of a version\n     *\/\n    public function revise(int $versionId, string $model): ContentGenerationResult\n    {\n        $result = $this->callPython('revise', $versionId, [$model]);\n\n        return ContentGenerationResult::fromPythonResult($result);\n    }\n\n    \/**\n     * Call Python script with command and arguments\n     *\n     * @param string $command Command to execute (generate, critique, revise)\n     * @param int $entityId Order or version ID\n     * @param array<mixed> $args Additional arguments\n     * @return array<string,mixed> Result from Python script\n     *\/\n    private function callPython(string $command, int $entityId, array $args = []): array\n    {\n        \/\/ Validate command against whitelist\n        if (!in_array($command, self::ALLOWED_COMMANDS, true)) {\n            return ['error' => 'Ungültiger Command: ' . $command];\n        }\n\n        $scriptPath = $this->pipelinePath . '\/web_generate.py';\n\n        \/\/ Build command array for proc_open (safer than shell_exec)\n        $cmdArray = [\n            $this->pythonPath,\n            $scriptPath,\n            $command,\n            (string) $entityId,\n            ...$args,\n        ];\n\n        $descriptors = [\n            0 => ['pipe', 'r'],\n            1 => ['pipe', 'w'],\n            2 => ['pipe', 'w'],\n        ];\n\n        $process = proc_open($cmdArray, $descriptors, $pipes); \/\/ nosemgrep: exec-use\n\n        if (!is_resource($process)) {\n            return ['error' => 'Script konnte nicht gestartet werden'];\n        }\n\n        fclose($pipes[0]);\n        $stdout = stream_get_contents($pipes[1]);\n        $stderr = stream_get_contents($pipes[2]);\n        fclose($pipes[1]);\n        fclose($pipes[2]);\n        $exitCode = proc_close($process);\n\n        $output = $stdout . $stderr;\n\n        if ($exitCode !== 0 && $output === '') {\n            return ['error' => 'Script fehlgeschlagen (Exit: ' . $exitCode . ')'];\n        }\n\n        if (preg_match('\/\\{[\\s\\S]*\\}\/', $output, $matches)) {\n            $result = json_decode($matches[0], true);\n            if (json_last_error() === JSON_ERROR_NONE) {\n                return $result;\n            }\n        }\n\n        return ['error' => 'Ungültige Antwort: ' . substr($output, 0, 500)];\n    }\n}\n",
        "structuredPatch": [
            {
                "oldStart": 60,
                "oldLines": 7,
                "newStart": 60,
                "newLines": 7,
                "lines": [
                    "     }",
                    " ",
                    "     \/**",
                    "-     * Run critique on a version",
                    "+     * Run critique on a version (synchronous)",
                    "      *\/",
                    "     public function critique(int $versionId, string $model): ContentGenerationResult",
                    "     {"
                ]
            },
            {
                "oldStart": 70,
                "oldLines": 6,
                "newStart": 70,
                "newLines": 31,
                "lines": [
                    "     }",
                    " ",
                    "     \/**",
                    "+     * Start async critique (returns immediately)",
                    "+     *",
                    "+     * Note: Python script reads DB password directly from .env via config.py",
                    "+     *\/",
                    "+    public function critiqueAsync(int $orderId, int $versionId, string $model): bool",
                    "+    {",
                    "+        $scriptPath = $this->pipelinePath . '\/web_generate.py';",
                    "+        $logPath = '\/tmp\/content_critique_' . $orderId . '.log';",
                    "+",
                    "+        $cmd = sprintf(",
                    "+            'nohup %s %s critique %d %s %d > %s 2>&1 &',",
                    "+            escapeshellarg($this->pythonPath),",
                    "+            escapeshellarg($scriptPath),",
                    "+            $versionId,",
                    "+            escapeshellarg($model),",
                    "+            $orderId,",
                    "+            escapeshellarg($logPath)",
                    "+        );",
                    "+",
                    "+        exec($cmd); \/\/ nosemgrep: exec-use",
                    "+",
                    "+        return true;",
                    "+    }",
                    "+",
                    "+    \/**",
                    "      * Create revision of a version",
                    "      *\/",
                    "     public function revise(int $versionId, string $model): ContentGenerationResult"
                ]
            }
        ],
        "userModified": false,
        "replaceAll": false
    }
}